HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36700 )
Change subject: sb/intel/i82801gx: Add common LPC decode code ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36700/2/src/mainboard/getac/p470/de... File src/mainboard/getac/p470/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36700/2/src/mainboard/getac/p470/de... PS2, Line 66: register "gen1_dec" = "0x00fc0601" : register "gen1_dec" gen_2 and 3?
https://review.coreboot.org/c/coreboot/+/36700/1/src/mainboard/gigabyte/ga-g... File src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36700/1/src/mainboard/gigabyte/ga-g... PS1, Line 53: gen1_dec" pci_write_config32(PCI_DEV(0, 0x1f, 0), GEN2_DEC, 0x007c0291); ?
https://review.coreboot.org/c/coreboot/+/36700/1/src/mainboard/ibase/mb899/d... File src/mainboard/ibase/mb899/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36700/1/src/mainboard/ibase/mb899/d... PS1, Line 42: register "gen1_dec" = "0x00fc0291" : register "gen2_dec" = "0x00000301" pci_write_config32(PCI_DEV(0, 0x1f, 0), GEN1_DEC, 0x00fc0291); pci_write_config32(PCI_DEV(0, 0x1f, 0), GEN4_DEC, 0x00000301);