Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44387 )
Change subject: mb/ti/beaglebone: Initialize DDR3
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44387/12/src/mainboard/ti/beaglebon...
File src/mainboard/ti/beaglebone/ddr3.h:
https://review.coreboot.org/c/coreboot/+/44387/12/src/mainboard/ti/beaglebon...
PS12, Line 29: const struct ctrl_ioregs ioregs_bonelt = {
I'd avoid defining structs in headers (this can cause problems in the long run). Just put them in romstage.c or make a new raminit.c file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I692bfd913c8217a78d073d19c5344c9bb40722a8
Gerrit-Change-Number: 44387
Gerrit-PatchSet: 12
Gerrit-Owner: Sam Lewis
sam.vr.lewis@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 21:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment