Attention is currently required from: Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: mb/fujitsu/d3410-b1: Add new mainboard
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/fujitsu/d3410-b1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48383/comment/4d719b5b_7dddee8a
PS5, Line 126: irq 0x70 = 1
: irq 0x72 = 12
IRQ numbers are usually written in decimal, whereas addresses and register offsets are most often he […]
Ack
https://review.coreboot.org/c/coreboot/+/48383/comment/85957eaf_4090a69c
PS5, Line 163: io 0x62 = 0
: irq 0x70 = 0
:
In this case, it's to emphasize that these are disabled.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fd843cd783b0324866933b95dd46eaccb634ba8
Gerrit-Change-Number: 48383
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 04 Apr 2021 19:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment