Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34395 )
Change subject: sb/amd/sb800: Remove bit shift that does nothing
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34395/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34395/1//COMMIT_MSG@13
PS1, Line 13: bits 8 and 9 are already set by default, so we can remove the bit shift.
Since pm_iowrite() is eventually outb(), those bits 8 or 9 were neither read or written here, they […]
That would make sense. Do you think it's safe to try setting them there instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I645236441e02925ee01339378d213cb343027363
Gerrit-Change-Number: 34395
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 17:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment