Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 ) Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ...................................................................... Patch Set 13: (11 comments) https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig: https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... PS13, Line 2: config BOARD_SPECIFIC_OPTIONS Add `def_bool y` after this line, otherwise these options won't be selected. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... PS13, Line 9: select MAINBOARD_USES_FSP2_0 Not needed, since it is selected by the SOC. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... PS13, Line 12: select NO_POST # This platform does not have any way to see POST codes Sure, the log file. Remove this and add the following options below. config POST_IO bool default n config POST_DEVICE bool default n config CONSOLE_POST bool default y https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/ac.asl: PS13: Empty this file since the IASL compiler complains too much while building and at the moment we don't need them. Can be added later again. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/battery.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/ec.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/kb.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/mainboard.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/superio.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/acpi/tpm.asl: PS13: Same. https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/hda_verb.c: https://review.coreboot.org/c/coreboot/+/34946/13/src/mainboard/hp/spectre_x... PS13, Line 49: dev = SA_DEV_ROOT; SA_DEVFN_ROOT -- To view, visit https://review.coreboot.org/c/coreboot/+/34946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497 Gerrit-Change-Number: 34946 Gerrit-PatchSet: 13 Gerrit-Owner: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 01:28:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment