Attention is currently required from: Bora Guvendik, Anil Kumar K, Jakub Czapiga, Selma Bensaid, Tim Wawrzynczak.
Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63240 )
Change subject: libpayload/defconfig: enable vboot Lib Build
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63240/comment/4a84a9e7_df3edea1
PS3, Line 9: #3461454
Does it mean CONFIG_LP_CHROMEOS=y has to be set in depthcharge board/<BOARD>/defconfig ? […]
Thank you for the clarification.
In this case the alternative is to create a board specific defconfig in coreboot/payloads/libpayload/configs/config.<BOARD> and set CONFIG_LP_DEFCONFIG_OVERRIDE=n for coreboot build. This however means we need to duplicate the config.<BOARD> for every other chrome board.
Another alternative is to introduce another Kconfig in depthcharge and let it pick a config.chromeos
Is that a right understanding ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2bb2ce42a314e05ef22ea7b8abc067d6361d511
Gerrit-Change-Number: 63240
Gerrit-PatchSet: 3
Gerrit-Owner: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 08 Apr 2022 13:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-MessageType: comment