build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35366 )
Change subject: mb/google/drallion: add sku id base on sensor detection ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 21: int id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 22: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 27: { .id = 1, .name = "sku1" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 29: { .id = 2, .name = "sku2" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 31: { .id = 3, .name = "sku3" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35366/1/src/mainboard/google/dralli... PS1, Line 33: { .id = 4, .name = "sku4" }, please, no spaces at the start of a line