Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42134 )
Change subject: src/include: Add PnP/HWM unset_and_set functions
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42134/12/src/include/superio/hwm5_c...
File src/include/superio/hwm5_conf.h:
https://review.coreboot.org/c/coreboot/+/42134/12/src/include/superio/hwm5_c...
PS12, Line 52: port
Uh, the comments above are wrong then
yep, @param[in] u16 base isn't the address of the index register, but the base. the index register is base + 5.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica01211af2a9a00aed98880844a836f6b7957b14
Gerrit-Change-Number: 42134
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Aug 2020 21:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment