Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34838 )
Change subject: mb/up/squared: Do RAM config based on SKU ID
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34838/12/src/mainboard/up/squared/r...
File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34838/12/src/mainboard/up/squared/r...
PS12, Line 30: static const uint8_t memory_skuid_pads[] = { GPIO_214, GPIO_215 };
are the gpio pins in the right order here? if i read the code below correctly, the array element 0 becomes bit 0 in memory_skuid; the table beginning on line 61 suggests though that the state of gpio125 should become the lsb of memory_skuid.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic121652213d5b1f65cff2f3096e919a3cf88db72
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Sep 2019 12:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment