Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )
Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/Kco... File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/Kco... PS1, Line 26: SOC_INTEL_COMMON_BLOCK_ACPI Should go in as a separate change?
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/Mak... File src/soc/intel/alderlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/Mak... PS1, Line 20: bootblock-y += gpio.c : romstage-y += gpio.c : ramstage-y += gpio.c : smm-y += gpio.c I think these files are typically arranged in groups based on stages.
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... PS1, Line 9: GPIO Not for this change, but I would really like to see this getting generated using SSDT. I think we can take advantage of all the GPIO community tables we add in gpio.c.
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... PS1, Line 11: CROS_GPIO_NAME Have you verified that this matches the Linux kernel expectations? I know JSL and TGL used very different ways of handling the different communities.
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 27: The GPIO pinctrl driver for Alder Lake on Linux expects 32 GPIOs per pad Have you confirmed this?
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 36: This layout matches the Linux kernel pinctrl map for ADL at: : * linux/drivers/pinctrl/intel/pinctrl-alderlake.c What version of Linux kernel? I did not find this file in v5.9-rc6.