[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(906a0h) silicon

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Selma Bensaid, Sridhar Siricilla, Rizwan Qureshi, Werner Zeh.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56073 )

Change subject: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(906a0h) silicon
......................................................................

Patch Set 7:

(4 comments)

File src/mainboard/intel/adlrvp/bootblock.c:

https://review.coreboot.org/c/coreboot/+/56073/comment/c3540b50_158ff9e1 
PS6, Line 25: check_host_write_access_desc_region
> I would name it more distinct, maybe something like is_descriptor_writeable() or the like. […]

Ack

https://review.coreboot.org/c/coreboot/+/56073/comment/8cc9aa24_a0f08abf 
PS6, Line 28: if (*(uint32_t *)(desc + FLASH_SIGN_OFFSET) != FLASH_VAL_SIGN) {
> Would it make things more readable here if you use read32 here? Maybe something like: […]

Ack

https://review.coreboot.org/c/coreboot/+/56073/comment/f2c62ddc_dbf6cddc 
PS6, Line 36: *flmstr1
> Use read32() here as well?

Ack

https://review.coreboot.org/c/coreboot/+/56073/comment/ea8322b4_18d547d5 
PS6, Line 81: BIOS_DEBUG
> Should we use a lower log level here since it is a reset now? […]

Having the log before reset, it gives an idea reason for reset.
Yes, reset happens only once after CB flash.