[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/systemagent: Make northbridge.asl common

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )

Change subject: soc/intel/common/systemagent: Make northbridge.asl common
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38456/14/src/soc/intel/common/block... 
File src/soc/intel/common/block/acpi/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38456/14/src/soc/intel/common/block... 
PS14, Line 241: ShiftLeft (1, Add (CONFIG_SA_MCHBAR_GRANULARITY, 1), Local0)
> Furquan, was thinking if we can make ASL2. […]

Ack. Sounds okay to me.

https://review.coreboot.org/c/coreboot/+/38456/14/src/soc/intel/common/block... 
File src/soc/intel/common/block/systemagent/Kconfig:

https://review.coreboot.org/c/coreboot/+/38456/14/src/soc/intel/common/block... 
PS14, Line 14: This field corresponds to the reserved bits (bit 1 onwards) of MCHBAR register.
> Refer to error  […]

Ah yes. FieldUnit allows only constant values. Humm...