Attention is currently required from: Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held. Hello build bot (Jenkins), Raul Rangel, Nico Huber, Furquan Shaikh, Matt DeVillier, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52493
to look at the new patch set (#16).
Change subject: [RFC] device: Introduce new method for setting device states ......................................................................
[RFC] device: Introduce new method for setting device states
We mostly use the same mechanism for setting the state of internal devices, but we copy it over again and again. Thus, introduce a new method trying to reduce redundant code.
Basically, this uses an array of structs containing the DEVFN number, its corresponding FSP option and an indicator if the FSP option is inverted. The struct maps the device to its related FSP option and `set_dev_state_by_devicetree()` iterates over the array using the usual mechanism.
Unresolved issues: - Where should fspdevmap{.c,.h} be implemented?
Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/Makefile.inc A src/device/devenmap.c A src/include/device/devenmap.h 3 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/52493/16