Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument
......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39430/10/src/mainboard/emulation/qe...
File src/mainboard/emulation/qemu-armv7/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/mainboard/emulation/qe...
PS10, Line 15: struct edid edid;
Left uninitialized?
Ack
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra124/di...
File src/soc/nvidia/tegra124/display.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra124/di...
PS10, Line 315: struct edid edid;
Left uninitialized?
Ack
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra210/dc...
File src/soc/nvidia/tegra210/dc.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra210/dc...
PS10, Line 216: struct edid edid;
Left uninitialized?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ce88193c5e324a2a7b04e0a7e3438172afca038
Gerrit-Change-Number: 39430
Gerrit-PatchSet: 14
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Aug 2020 18:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment