Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43308 )
Change subject: soc/amd/picasso: Init SPI speeds & mode in psp_verstage
......................................................................
Patch Set 3:
Patch Set 1:
Patch Set 1:
Matt,
Do the EFS settings remove the need for psp verstage to do this?
I dont know for sure, did not get a clear answer when I asked Avinash. Sure seems logical that is the case because otherwise what is the point? It is clearly working now without it.
I can find out for sure by taking the time before and after my change. Let me finish updating my patch stack and see what the results are. Martin, what improvement % on boot time were you seeing? Just to sanity check anything I see
Any progress Matt?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebf3ed3f5d6be0dda717d91d5b2fbcf2a1cc43cc
Gerrit-Change-Number: 43308
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 16:47:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment