23 Nov
2022
23 Nov
'22
2:44 a.m.
Attention is currently required from: Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69761 )
Change subject: vboot/vboot_common: Fix vboot_save_data() code exclusion guard ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69761/comment/060f69eb_18b11b6c PS4, Line 12: reduction of undefined references. I find this hard to believe... this looks like a purely cosmetic change to me that should make no difference to the compiler. Can you explain what exactly you built and where you found evidence of bad code generation?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5330efeeb4cfd7477cf8f7f64c6abed68281e30
Gerrit-Change-Number: 69761
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 00:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment