Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47450 )
Change subject: soc/intel/denverton_ns: Hook up SMMSTORE ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47450/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47450/3//COMMIT_MSG@9 PS3, Line 9: Tested
How? Change an option in TianoCore?
I didn't test myself, so I'm not 100% sure. I know that the V2 error message about the com buffer not being installed will be gone away, though.
https://review.coreboot.org/c/coreboot/+/47450/3/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/smihandler.c:
https://review.coreboot.org/c/coreboot/+/47450/3/src/soc/intel/denverton_ns/... PS3, Line 201: static void southbridge_smi_store(void) : { : u8 sub_command, ret; : em64t100_smm_state_save_area_t *io_smi = : smi_apmc_find_state_save(APM_CNT_SMMSTORE); : uint32_t reg_ebx; : : if (!io_smi) : return; : /* Command and return value in EAX */ : sub_command = (io_smi->rax >> 8) & 0xff; : : /* Parameter buffer in EBX */ : reg_ebx = io_smi->rbx; : : /* drivers/smmstore/smi.c */ : ret = smmstore_exec(sub_command, (void *)reg_ebx); : io_smi->rax = ret; : }
I don't think so tbh. IIRC dnv_ns isn't using common code, yet, though. […]
The SMM save state version is chip-specific. Arthur wants to deduplicate this so this will eventually be deduplicated.