Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35224 )
Change subject: soc/intel/common/block/cse: Add helper function heci_send_receive ......................................................................
Patch Set 7: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... PS7, Line 462: size_t *rcv_sz) Minor: this fits on the previous line (line length limit is 96 characters)
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... PS7, Line 465: Heci Send Failed To be consistent with the other messages in this file, please use "HECI: send failed\n"
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... PS7, Line 471: Heci receive Failed "HECI: receive failed\n"
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/... PS7, Line 47: size_t *rcv_sz); This would also fit on the previous line