Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65072 )
Change subject: soc/intel/adl: Add missing claimed memory regions ......................................................................
Patch Set 30:
(3 comments)
Patchset:
PS30: Subrata resolved in a followup CL (CB:65263 )
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/65072/comment/414a7b2f_48d89a6b PS30, Line 115: uint64_t mask = pci_read_config32(dev, MSR_PRMRR_PHYS_MASK); : base = pci_read_config32(dev, MSR_PRMRR_PHYS_BASE) & mask;
something is very wrong ? we can't do `pci_read_config32` to MSR offset 0x1f4 and 0x1f5. […]
Done
https://review.coreboot.org/c/coreboot/+/65072/comment/f20059c9_3d65fe97 PS30, Line 116: base = pci_read_config32(dev, MSR_PRMRR_PHYS_BASE) & mask;
this is no more valid on ADL.
Done