Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38036 )
Change subject: [UNTESTED] nb/intel/sandybridge: Add a bunch of MCHBAR defines ......................................................................
Patch Set 4:
(1 comment)
Patch Set 4:
(3 comments)
haven't checked the register numbers, but didn't spot anything that should be different after the preprocessor run. what i'd suggest you to try would be running the preprocessor on the files before and after the patch and diff the result; i'd expect that there's some typo in a register number or wrong register replacement
Good idea, thanks for the tip. I compared the object files, and the size of romstage raminit_common.o is sliiightly larger. I wonder why.
https://review.coreboot.org/c/coreboot/+/38036/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/38036/4/src/northbridge/intel/sandy... PS4, Line 2396: IOSAV_B0_BW_SERROR_C_C0
i'd put that before the 0x400 * ...
I'm replacing these macros with indexed equivalents later anyway. I didn't squash both commits though, because the latter changes the build significantly...