Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31458 )
Change subject: drivers/intel/gma: Export Read_EDID() to C
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31458/3/src/drivers/intel/gma/gma.a...
File src/drivers/intel/gma/gma.ads:
https://review.coreboot.org/c/coreboot/+/31458/3/src/drivers/intel/gma/gma.a...
PS3, Line 7: read_edid
Sorry, the whole series is stalled by the zero review progress on the […]
Ack. IMHO, having different code style conventions for C and Ada helps to tell things apart rather quickly, because of the associations I do:
- 'snake_lower_case' is usually C
- 'Snake_Capitalized_Case' is usually Ada
- 'CamelCase' is C code that needs fixing/a rewrite
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf802904c569e621ca3b3105b6107936776c5cee
Gerrit-Change-Number: 31458
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 20:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment