Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45153
to review the following change.
Change subject: mb/google/zork:Add dptc interface support ......................................................................
mb/google/zork:Add dptc interface support
Add dptc interface in devicetree.the variants can set below power parameters in overridetree as below ex: dptc_enable = 1 dptc_fast_ppt_limit = 24000 dptc_slow_ppt_limit = 20000 dptc_sustained_power_limit = 6000
BUG=b:157943445 BRANCH=none TEST=Build. check the setting changed.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I4dac4b7e5157ad7ad407f42a6fc6b06eefbf3291 --- M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/mainboard/google/zork/variants/baseboard/include/baseboard/thermal.h 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/45153/1
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb index 42219d7..f240a7c 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb @@ -40,6 +40,8 @@
# End : OPN Performance Configuration
+ register "dptc_enable" = "0" + register "sd_emmc_config" = "SD_EMMC_EMMC_HS400"
register "xhci0_force_gen1" = "0" diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 1620643..50fadae 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -40,6 +40,8 @@
# End : OPN Performance Configuration
+ register "dptc_enable" = "0" + register "sd_emmc_config" = "SD_EMMC_EMMC_HS400"
register "xhci0_force_gen1" = "0" diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/thermal.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/thermal.h index b3c951b..fd110cc 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/thermal.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/thermal.h @@ -3,6 +3,8 @@ #ifndef THERMAL_H #define THERMAL_H
+#define DPTC_SUPPORT_ENABLE + /* * Picasso Thermal Requirements * TDP (W) 15