Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56763 )
Change subject: arch/x86/acpi: rename KEY_KBDILLUMTOGGLE to KEY_KBD_BKLIGHT_TOGGLE ......................................................................
arch/x86/acpi: rename KEY_KBDILLUMTOGGLE to KEY_KBD_BKLIGHT_TOGGLE
Also change scan code from e02b to e01e. This is trying to fill the gaps in the standard table. The advise from Googler is using e01e for the keyboard backlight toggle key.
BUG=b:194146863 BRANCH=none TEST=check on evtest
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: I402192ff354f30da35aec43202df9f1407911d34 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56763 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/acpigen_ps2_keybd.c M src/include/acpi/acpigen_ps2_keybd.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 3890f26..c65790d 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -55,7 +55,7 @@ [PS2_KEY_PRIVACY_SCRN_TOGGLE] = KEYMAP(0x96, /* e016 */ KEY_PRIVACY_SCREEN_TOGGLE), [PS2_KEY_MICMUTE] = KEYMAP(0x9b, KEY_MICMUTE), /* e01b */ - [PS2_KEY_KBDILLUMTOGGLE] = KEYMAP(0xab, KEY_KBDILLUMTOGGLE), /* e02b */ + [PS2_KEY_KBD_BKLIGHT_TOGGLE] = KEYMAP(0x9e, KEY_KBDILLUMTOGGLE), /* e01e */ };
/* Keymap for numeric keypad keys */ diff --git a/src/include/acpi/acpigen_ps2_keybd.h b/src/include/acpi/acpigen_ps2_keybd.h index 6221d87..e32ca2a 100644 --- a/src/include/acpi/acpigen_ps2_keybd.h +++ b/src/include/acpi/acpigen_ps2_keybd.h @@ -24,7 +24,7 @@ PS2_KEY_PLAY_PAUSE, PS2_KEY_NEXT_TRACK, PS2_KEY_PREV_TRACK, - PS2_KEY_KBDILLUMTOGGLE, + PS2_KEY_KBD_BKLIGHT_TOGGLE, PS2_KEY_MICMUTE, };