[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)

[Felix Singer (Code Review)]

Attention is currently required from: Ravi Mistry.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320?usp=email )

Change subject: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)
......................................................................

Patch Set 9:

(14 comments)

Patchset:

PS9: 
Some clean ups and reformattings. Thanks!

File src/mainboard/hp/memphis-s/Kconfig:

https://review.coreboot.org/c/coreboot/+/69320/comment/6c1a479e_411a3e23 :
PS9, Line 20: 	string
Remove, type redefinition

https://review.coreboot.org/c/coreboot/+/69320/comment/69a69a02_a2ecbe1d :
PS9, Line 24: 	string
Remove, type redefinition

https://review.coreboot.org/c/coreboot/+/69320/comment/60e92f08_e9829e9e :
PS9, Line 28: 	string
Remove, type redefinition

https://review.coreboot.org/c/coreboot/+/69320/comment/49e3e609_92eff854 :
PS9, Line 31: #config USBDEBUG_HCD_INDEX
            : #    int
            : #    default 2
            : # 
This should go into the documentation instead of here.

File src/mainboard/hp/memphis-s/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/69320/comment/f8fd15e3_7229a950 :
PS9, Line 7: 	register "ec_present" = "false"
Remove. False equals to zero, which is the default.

https://review.coreboot.org/c/coreboot/+/69320/comment/9681ecf4_b1ddc2f9 :
PS9, Line 8: device cpu_cluster 0x0 on
           : 		chip cpu/intel/haswell
           : 			device lapic 0x0 on
           : 			end
           : 			device lapic 0xacac off
           : 			end
           : 		end
           : 	end
Replace with
```
device cpu_cluster 0 on ops haswell_cpu_bus_ops end
```

https://review.coreboot.org/c/coreboot/+/69320/comment/fd09c0bd_c20c3f72 :
PS9, Line 18: 			register "docking_supported" = "0"
Remove

https://review.coreboot.org/c/coreboot/+/69320/comment/559f5e77_2bd8b466 :
PS9, Line 21: 			register "gpe0_en_2" = "0x0"
Remove

https://review.coreboot.org/c/coreboot/+/69320/comment/de5f6364_51a2906b :
PS9, Line 26: subsystemid 0x103c 0x2af7
Move one level higher and change it to the following. Remove all other occurrences as well.

subsystemid 0x103c 0x2af7 inherit

https://review.coreboot.org/c/coreboot/+/69320/comment/70dc7808_f166e317 :
PS9, Line 32: end
Please move the end keyword into the previous line if the block doesn't contain configuration.

https://review.coreboot.org/c/coreboot/+/69320/comment/dc9bbe03_a3cb8400 :
PS9, Line 69:                         		register "multi_function_register_0" = "0x00"
Remove

File src/mainboard/hp/memphis-s/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/69320/comment/85921f16_955003e9 :
PS9, Line 20: 
While on it, please remove empty line

File src/mainboard/hp/memphis-s/romstage.c:

https://review.coreboot.org/c/coreboot/+/69320/comment/2af5fb8b_b7cb314d :
PS9, Line 43: 	{1, 0}, {1, 0}, {1, 1}, {1, 1}, {1, 2}, {1, 2},
Put each in a separate line