HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32533/6/src/southbridge/intel/common/watchdo...
File src/southbridge/intel/common/watchdog.c:
https://review.coreboot.org/#/c/32533/6/src/southbridge/intel/common/watchdo...
PS6, Line 40: value = pci_read_config16(dev, PCI_COMMAND);
: value |= PCI_COMMAND_INT_DISABLE;
: pci_write_config16(dev, PCI_COMMAND, value);
this seems to be wrong on the chip I have.
this value is = 0x0007 before and after the pci_write
(on I82801GX)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 01 May 2019 17:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment