Vincent Palatin has posted comments on this change. ( https://review.coreboot.org/27221 )
Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... PS1, Line 138: NONE
a 20k pulldown here would help for preEVT2 devices (preEVT2 is missing a pd in hw on this line; EVT2 […]
As mentioned in b/78613978#comment10 given this is an active-low interrupt, the pull-down is doing the opposite of what we want, we would like a pull-up.