[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/fsp2_0: Add low battery indicator screen

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Jérémy Compostella, Karthik Ramasubramanian, Ronak Kanabar, Subrata Banik.

Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )

Change subject: drivers/intel/fsp2_0: Add low battery indicator screen
......................................................................

Patch Set 10: Code-Review+2

(1 comment)

File src/vendorcode/google/chromeos/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/86225/comment/7256a5e5_65c9cb18?usp... :
PS8, Line 45: 	      low_battery.bmp,CONFIG_PLATFORM_LOW_BATTERY_INDICATOR_LOGO_PATH))
> > This should go either in `fsp2_0/Makefile.mk` or in `src/lib/Makefile.mk` (because `bmp_logo. […]

Oh, okay, so we have it there. I didn't see that. It is kinda weird though that the code that uses it is in `src/lib`, but the code adding that logo is in `src/drivers/intel/fsp2_0` (so if you used the splash screen on a non-Intel board you wouldn't actually get the logo in your CBFS).

Not really related to this patch but it would probably make sense to move that part into `src/lib/Makefile.mk` at some point.