[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/lpc: Include correct acpi.h

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48251 )

Change subject: soc/intel/common/block/lpc: Include correct acpi.h
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... 
File src/soc/intel/common/block/lpc/lpc.c:

https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... 
PS3, Line 14: <soc/acpi.h>
> It is not clear to me why soc/acpi.h is required. I think intelblocks/acpi. […]

Yes, that is the problem. It should pick up the soc/*/include/soc/acpi.h where the soc acpi functions are defined and it doesn't use the common block acpi. A later change to intelblocks/acpi.h has issues with duplicate defines . See soc/skylake as an example. https://qa.coreboot.org/job/coreboot-gerrit/154009/testReport/junit/board/ch...