Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33621/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33621/5//COMMIT_MSG@9 PS5, Line 9: In preparation to add board padmelon,
There's no reason to talk about preparing for a board. […]
Will remove the highlighted.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 33: bool
Look at line 202. […]
Ok, will look and decide.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 347: <codename>
You forgot to address this comment https://review.coreboot. […]
Oops... next patch
https://review.coreboot.org/c/coreboot/+/33621/3/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33621/3/src/soc/amd/stoneyridge/Mak... PS3, Line 204: endif
Can you try again please? I tried it before I suggested it to you, and it still builds OK on my sid […]
Ok, will try again.