Ariel Otilibili has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85783?usp=email )
Change subject: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long' ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/85783/comment/ca64144c_d6a87c42?usp... : PS1, Line 131: }
Wondering if this cast is needed
Hello Elyes,
Thanks for having looked the patch. It seems so, fsp_reserved_bytes was declared as u32 [1], and depending the host, unsigned long and u32 may have different lengths [2].
[1] https://github.com/coreboot/coreboot/blob/aba7f44ecd3925c91f4249e03024af1349... [2] https://michas.eu/blog/c_ints.php?lang=en