[coreboot-gerrit] Change in coreboot[master]: util/inteltool: spi: make Sunrise Point dumping work

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39564 )

Change subject: util/inteltool: spi: make Sunrise Point dumping work
......................................................................

Patch Set 3: Code-Review-1

(2 comments)

haven't checked the register offsets/names and found a bug; the rest looks good

https://review.coreboot.org/c/coreboot/+/39564/3/util/inteltool/spi.c 
File util/inteltool/spi.c:

https://review.coreboot.org/c/coreboot/+/39564/3/util/inteltool/spi.c@260 
PS3, Line 260: static int print_spibar(struct pci_dev *sb, struct pci_access *pacc) {
moving this line one down seems to be a bug to me

https://review.coreboot.org/c/coreboot/+/39564/3/util/inteltool/spi.c@428 
PS3, Line 428: *(uint8_t *)
those could be replaced in some follow-up patch. maybe that patch even exists; wasn't in this patch train though