[coreboot-gerrit] [XS] Change in coreboot[main]: amdfwtool: function getopt prints usage only once and returns

[Felix Held (Code Review)]

Attention is currently required from: Bao Zheng, Zheng Bao.

Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/81929?usp=email )

Change subject: amdfwtool: function getopt prints usage only once and returns
......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81929/comment/0e9c0241_be0bfdef?usp... :
PS3, Line 7: amdfwtool: function getopt prints usage only once and returns
maybe change the first line of the commit message to "amdfwtool: exit program after printing usage" and add another sentence explaining the reason

File util/amdfwtool/opts.c:

https://review.coreboot.org/c/coreboot/+/81929/comment/d845e72a_e2833ea4?usp... :
PS3, Line 604: 			retval = 1;
             : 			return retval;
the two lines could be simplified to "return 1;". i also don't think that the break after the return is still needed, but haven't verified that one