Attention is currently required from: Nico Huber.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75620?usp=email )
Change subject: soc/intel/common: Use memcpy library function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
If I found the right types, `hotfix` and `build` are swapped.
You are right..binary_version and fw_version are different user defined types.
struct {
uint16_t major;
uint16_t minor;
uint16_t build;
uint16_t hotfix;
} binary_version;
struct fw_version {
uint16_t major;
uint16_t minor;
uint16_t hotfix;
uint16_t build;
} __packed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75620?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff6c9a663e9e3f80cf3fb2f6d6203a95c3fea20c
Gerrit-Change-Number: 75620
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 04:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment