Attention is currently required from: Jamie Chen, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78427?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/omnigul: Add fingerprint SPI
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/omnigul/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78427/comment/046f330e_ea7349ff :
PS9, Line 337: n
mind changing this to hidden to be consistent with the change made to other brya boards?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78427?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7b9e29ca3cb9352fe098156924fde2719399a79
Gerrit-Change-Number: 78427
Gerrit-PatchSet: 9
Gerrit-Owner: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 15:35:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment