Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10780
-gerrit
commit 4838e367d7019b9e6fe2acb3257ce2260fdc1238 Author: Furquan Shaikh furquan@google.com Date: Tue Jun 16 13:02:40 2015 -0700
t210: MTC cleanup
1. Correct MTC weak function definitions. 2. Correct MTC message in case no training data is present.
BUG=None BRANCH=None TEST=Compiles successfully and boots to kernel prompt on smaug.
Change-Id: Iba3c994982da947af3fbd2d7e9a06dff7947f2b9 Signed-off-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Id: ce9a4cd7d824acd0da5615b33319869f6cf1cd56 Original-Change-Id: I037439246709c8ec0ec7f12ea109cbe0ae1073ae Original-Signed-off-by: Furquan Shaikh furquan@google.com Original-Reviewed-on: https://chromium-review.googlesource.com/278027 Original-Trybot-Ready: Furquan Shaikh furquan@chromium.org Original-Tested-by: Furquan Shaikh furquan@chromium.org Original-Reviewed-by: Tom Warren twarren@nvidia.com Original-Reviewed-by: Stefan Reinauer reinauer@chromium.org Original-Reviewed-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Queue: Furquan Shaikh furquan@chromium.org --- src/soc/nvidia/tegra210/include/soc/mtc.h | 2 +- src/soc/nvidia/tegra210/soc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/nvidia/tegra210/include/soc/mtc.h b/src/soc/nvidia/tegra210/include/soc/mtc.h index c94d79b..c9f19cb 100644 --- a/src/soc/nvidia/tegra210/include/soc/mtc.h +++ b/src/soc/nvidia/tegra210/include/soc/mtc.h @@ -29,7 +29,7 @@ void soc_add_mtc(struct lb_header *header);
#else
-static inline int tegra210_run_mtc(void) { return -1; } +static inline int tegra210_run_mtc(void) { return 0; } static inline void soc_add_mtc(struct lb_header *header) {}
#endif /* CONFIG_HAVE_MTC */ diff --git a/src/soc/nvidia/tegra210/soc.c b/src/soc/nvidia/tegra210/soc.c index f3290c3..7d91bc5 100644 --- a/src/soc/nvidia/tegra210/soc.c +++ b/src/soc/nvidia/tegra210/soc.c @@ -156,7 +156,7 @@ static void tegra210_cpu_init(device_t cpu) { if (cpu_is_bsp()) if (tegra210_run_mtc() != 0) - printk(BIOS_ERR, "MTC: Training failed\n"); + printk(BIOS_ERR, "MTC: No training data.\n"); }
static const struct cpu_device_id ids[] = {