HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45613 )
Change subject: nb/{gm45,haswell,i945,ironlake,pineview,sandybridge,x4x}: Move DEFAULT_BARs to Kconfig ......................................................................
Patch Set 10:
(2 comments)
Thank you
https://review.coreboot.org/c/coreboot/+/45613/10/src/northbridge/intel/hasw... File src/northbridge/intel/haswell/memmap.h:
https://review.coreboot.org/c/coreboot/+/45613/10/src/northbridge/intel/hasw... PS10, Line 10: /* 16 KB */
This is wrong
out of scope. but I'll remove it
https://review.coreboot.org/c/coreboot/+/45613/10/src/northbridge/intel/sand... File src/northbridge/intel/sandybridge/memmap.h:
https://review.coreboot.org/c/coreboot/+/45613/10/src/northbridge/intel/sand... PS10, Line 7: /* 16 KB */
This is wrong
out of scope. but I'll remove it