[coreboot-gerrit] [S] Change in coreboot[main]: soc/mediatek/mt8196: Save HW protect temperature to SRAM

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86551?usp=email )

Change subject: soc/mediatek/mt8196: Save HW protect temperature to SRAM
......................................................................

Patch Set 2:

(3 comments)

File src/soc/mediatek/mt8196/thermal.c:

https://review.coreboot.org/c/coreboot/+/86551/comment/382005e2_ec8e6ef4?usp... :
PS2, Line 626: const struct lvts_thermal_controller *tc = &lvts_tscpu_g_tc[i];
             : 		if (tc->ctrl_on_off == CTRL_OFF)
             : 			continue;
you can still keep those.

https://review.coreboot.org/c/coreboot/+/86551/comment/bcffbec2_e41dafa0?usp... :
PS2, Line 606: 	if (tc_num == LVTS_AP_CONTROLLER0)
             : 		tc_index = 0;
             : 	else if (tc_num == LVTS_AP_CONTROLLER1)
             : 		tc_index = 1;
             : 
             : 	if (tc_index != 0xff) {
             : 		thermal_write_reboot_msr_sram(tc_index, raw_high);
             : 		if (tc_index == 0)
             : 			thermal_write_reboot_temp_sram(tc->reboot_temperature);
             : 	}
```
if (tc_num == LVTS_AP_CONTROLLER0 || tc_num == LVTS_AP_CONTROLLER1) {
    thermal_write_reboot_msr_sram(tc_num, raw_high);
    if (tc_num == LVTS_AP_CONTROLLER0)
        thermal_write_reboot_temp_sram(tc->reboot_temperature);
}
```

File src/soc/mediatek/mt8196/thermal_sram.c:

https://review.coreboot.org/c/coreboot/+/86551/comment/57ef3bb0_3d94d8e3?usp... :
PS2, Line 68: write32
write32p ?