Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38367 )
Change subject: sb/intel/i82371eb: Add PIIX4 definitions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38367/1/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/i82371eb.h:
https://review.coreboot.org/c/coreboot/+/38367/1/src/southbridge/intel/i8237...
PS1, Line 43: (1<<28)
These should use spaces:
(1 << 28)
However, the rest of this file seems to be using this format, so it would be better to change that on a separate patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I242244c444f36af188c871dce037a7a9250206cd
Gerrit-Change-Number: 38367
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 11 Jan 2020 22:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment