John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42149 )
Change subject: soc/intel/tigerlake: Add Hot-Plug and PME event handlers for Thunderbolt ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42149/7/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42149/7/src/soc/intel/tigerlake/acp... PS7, Line 329: Printf("Bring TBT RPs out of D3Code.")
these seem like they could still be useful?
Done
https://review.coreboot.org/c/coreboot/+/42149/7/src/soc/intel/tigerlake/acp... PS7, Line 145: {
pleas pull these { to the same line as If() statements for consistency
Ack
https://review.coreboot.org/c/coreboot/+/42149/7/src/soc/intel/tigerlake/acp... PS7, Line 162: prior booting to OS.
this comment about 'prior to booting to OS' seems out of place in a runtime hotplug event.
Done
https://review.coreboot.org/c/coreboot/+/42149/7/src/soc/intel/tigerlake/acp... PS7, Line 257: _SB.PCI0.TRP0.HPME() : _SB.PCI0.TRP1.HPME() : _SB.PCI0.TRP2.HPME() : _SB.PCI0.TRP3.HPME()
should this be in Else() so it doesn't consume a PME notification? or if this is intentional can yo […]
It is intentional. Just added comments along with the invocation.