Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24904 )
Change subject: security/vboot: Add interface for FSP 2.0 mrc caching ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/#/c/24904/6/src/drivers/intel/fsp2_0/memory_init... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/24904/6/src/drivers/intel/fsp2_0/memory_init... PS6, Line 149: if (!mrc_cache_verify_hash(data, region_device_sz(&rdev)))
if you guard that with if (IS_ENABLED(CONFIG_FSP2_0_USES_TPM_MRC_HASH)), you don't need to define w […]
We want have multiple implementations here
https://review.coreboot.org/#/c/24904/6/src/security/vboot/mrc_cache_hash_tp... File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/#/c/24904/6/src/security/vboot/mrc_cache_hash_tp... PS6, Line 1: /*
You are breaking fsp2_0 memory_init.c here, as you are missing Makefile. […]
Done