Attention is currently required from: Maximilian Brune, Angel Pons, David Milosevic.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/prodrive/atlas/emi.c:
https://review.coreboot.org/c/coreboot/+/68137/comment/13790bdf_6d9fc98b
PS6, Line 83: {
It does not worsen readability at all. Those are mostly independent functions. […]
personally I think it makes sense to keep the write function, because:
1. it can be used for testing/debug when needed
2. since this is quite generic to EC we could also move it to common code/lib later on
3. a good reference
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
Gerrit-Change-Number: 68137
Gerrit-PatchSet: 8
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 14:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com
Gerrit-MessageType: comment