Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42056 )
Change subject: soc/intel/tigerlake: Set FSPS UPD ITbtConnectTopologyTimeoutInMs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42056/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42056/1/src/soc/intel/tigerlake/fsp...
PS1, Line 117: Set
CNTP is supposed to be skipped for SW CM. […]
sorry, for not being clear.
could you update the comment to indicate that a value of 0 here means
CNTP disabled or no-waiting... the comment doesn't even need to be that
technical, just some words to indicate to the reader that a timeout of 0
disables waiting rather than waiting forever.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47e3519fd818cb56e6abd16464d8370ffddabc5b
Gerrit-Change-Number: 42056
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 06 Jun 2020 00:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment