Attention is currently required from: Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47336 )
Change subject: soc/intel/elkhartlake: Add Initial support for Intel PSE
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47336/comment/dc255b85_19186317
PS1, Line 69: params->SiipRegionSize = psefwsize;
Please clean up the code (missing closing curly, remove unused psebase, do not guard "mainboard_silicon_init_params(params);" with "if (CONFIG(PSE_IMAGE)){".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96e779021938689e0f9a96046b9c292f3ff1db4e
Gerrit-Change-Number: 47336
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Comment-Date: Mon, 15 Feb 2021 06:17:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment