build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 49: CBFS_TYPE_RAW); code indent should use tabs where possible
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 49: CBFS_TYPE_RAW); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 55: buf[0], fw_size - 1, buf[fw_size - 1]); code indent should use tabs where possible
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 55: buf[0], fw_size - 1, buf[fw_size - 1]); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c File src/soc/mediatek/mt8183/sspm.c:
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c@25 PS1, Line 25: memcpy((void*)CFG_SSPM_SRAM, buf, len); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/sspm.c@30 PS1, Line 30: mb(); memory barrier without comment