Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/alderlake/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134365): https://review.coreboot.org/c/coreboot/+/59666/comment/a7cfbd07_3de0300c PS5, Line 19: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134365): https://review.coreboot.org/c/coreboot/+/59666/comment/d7b9842b_0f0c20a7 PS5, Line 31: die("Couldn't find correct port mapping or Invalid input port \n"); unnecessary whitespace before a quoted newline