Attention is currently required from: Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63748 )
Change subject: libpayload: Support x86 payload loaded via Linux Boot Protocol ......................................................................
Patch Set 1:
(2 comments)
File payloads/libpayload/arch/x86/head.S:
https://review.coreboot.org/c/coreboot/+/63748/comment/75dbb433_c05585f6 PS1, Line 86: jne 1f (Note that as far as I can tell, this hasn't worked in a long time, maybe ever(?)... so we always go into the 1f path here.)
https://review.coreboot.org/c/coreboot/+/63748/comment/43d31619_128ab634 PS1, Line 105: esi Where does %esi come from? Is the caller supposed to set it? That would be a problem for callers that don't follow this convention, obviously... (might be random value that points into invalid memory, generating a fault).