Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/shuboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v...
PS2, Line 13: register "slow_ppt_limit" = "6000" #mw
: register "fast_ppt_limit" = "9000" #mw
: register "slow_ppt_time_constant" = "5" #second
: register "stapm_time_constant" = "2500" #second
: register "sustained_power_limit" = "4800" #mw
quick heads-up: i submitted https://review.coreboot.org/c/coreboot/+/46840 into upstream today that changes those names. re-running create_coreboot_variant.sh after pulling the last changes should fix that issue
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679
Gerrit-Change-Number: 47152
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Randy I-Fan Wang
ifanw@google.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 21:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment