Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )
Change subject: soc/intel/cannonlake: Add ability to disable Heci1
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32992/4/src/soc/intel/cannonlake/chip.h
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/32992/4/src/soc/intel/cannonlake/chip.h@216
PS4, Line 216: /* HeciEnabled decides the state of Heci1 at end of boot
: * Setting to 0 (default) disables Heci1 and hides the device from OS */
: uint8_t HeciEnabled;
Why are we not using this config?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c63316c8b04fb101d34064daac5ba4fdc05a63c
Gerrit-Change-Number: 32992
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 31 May 2019 02:03:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment