Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39470 )
Change subject: soc/intel/tigerlake: Publish single GPIO ACPI device for Jasper Lake ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39470/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39470/3//COMMIT_MSG@14 PS3, Line 14: 150154277
Nit: b:150154277
Done
https://review.coreboot.org/c/coreboot/+/39470/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39470/3/src/soc/intel/tigerlake/acp... PS3, Line 121: Method (GADD, 1, NotSerialized)
This ACPI method looks identical between the two. […]
No downside, can be done. Just that it would be easy to pick the changes , when we do a jsl soc split. Please let me know your thoughts, I can make that change