Attention is currently required from: Hung-Te Lin. Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51203 )
Change subject: src/mediatek/common: Move DRAM implementation from mt8192 to common ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS1:
Hmmm. Can you try to do 'move' instead of 'add'? […]
OK.
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/51203/comment/7a4f359a_b0c0a1e3 PS1, Line 1: config MEDIATEK_DRAM_DVFS : bool : default n : help : This option enables DRAM calibration with multiple frequencies (low, : medium and high frequency groups, with total 7 frequencies) for DVFS : feature. All supported data rates are: 800, 1200, 1600, 1866, 2400, : 3200, 4266. : : config MEDIATEK_DRAM_DVFS_LIMIT_FREQ_CNT : bool : default y : select MEDIATEK_DRAM_DVFS : help : This options limit DRAM frequency calibration count from total 7 to 3, : other frequency will directly use the low frequency shu result. : : config MEMORY_TEST : bool : default y : help : This option enables memory basic compare test to verify the DRAM read : or write is as expected. :
I think we have to move this to an if-block so only MTK platforms will have these options, otherwise […]
Got it, i thought that soc/mediatek/xxx are only for MEDIATEK SOCs, right, needs to add SOC_MEDIATEK_COMMON config.
File src/soc/mediatek/common/dram_init.c:
https://review.coreboot.org/c/coreboot/+/51203/comment/e58e03d8_fb0ac1f4 PS1, Line 10: extern void (*do_putc)(unsigned char c);
I think we don't need this anymore?
yes, no need, remove it.
https://review.coreboot.org/c/coreboot/+/51203/comment/96f2d5f3_4bf7e3ad PS1, Line 30: const
If mt_set_emi can't take const, what about just removing the const for init_dram_by_params? […]
Ack
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/51203/comment/87b4c148_8665c388 PS1, Line 28: } else { : printk(BIOS_DEBUG, "[MEM] complex R/W mem test passed\n"); : } :
remove the else and move the printk to either add printing rank number, or move to outside of the fo […]
Done